----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120980/#review69831 -----------------------------------------------------------
Ship it! Looks good, some minor fixes and this can go in. browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp <https://git.reviewboard.kde.org/r/120980/#comment48875> pull m_musicFilteredModel->index(i, 0) into a variable browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp <https://git.reviewboard.kde.org/r/120980/#comment48876> use auto libs/mediacenter/abstractbrowsingbackend.cpp <https://git.reviewboard.kde.org/r/120980/#comment48874> return QStringList(); - Shantanu Tushar On Nov. 4, 2014, 1:44 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120980/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 1:44 p.m.) > > > Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and > Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > - AbstractBrowsingBackend::allMedia() returns all media in QStringList > - PlaylistModel::addAllToPlaylist() to add QStringList in current playlist > - This all is handled by mediabrowser and playlist.qml > > > Diffs > ----- > > browsingbackends/metadatamusicbackend/metadatamusicbackend.h > c9f10a77753f7427f669da9cb5e46cf66994f57d > browsingbackends/metadatamusicbackend/metadatamusicbackend.cpp > f4f908047586694188a354bc69ecc49824f15fe7 > libs/mediacenter/abstractbrowsingbackend.h > 910272a93ec047418ad1a4c6534592bb20fcba60 > libs/mediacenter/abstractbrowsingbackend.cpp > c24d5178d91a09b4e9f8b5b74d7a88616a8b9756 > libs/mediacenter/playlistmodel.h d45611c1eaddb657ce3ed97731e9e70990b7a060 > libs/mediacenter/playlistmodel.cpp 501e501888d53fd0fdd6574a72988408307b3f7b > mediaelements/mediabrowser/MediaBrowser.qml > 97942881d08c12539675ba08d7fc6a8b28206fb5 > mediaelements/playlist/Playlist.qml > f39be2a8a695499fc05d69cd0c13d70e18356142 > shells/next/contents/views/Desktop.qml > 8ed3d1e2e013cbfd0aac9d0fca099901fac3f237 > > Diff: https://git.reviewboard.kde.org/r/120980/diff/ > > > Testing > ------- > > works fine > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
