----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121198/#review70740 -----------------------------------------------------------
Ship it! Ship It! - Thomas Lübking On Nov. 21, 2014, 11:04 vorm., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121198/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2014, 11:04 vorm.) > > > Review request for KDE Frameworks, kwin and Plasma. > > > Bugs: 340310 > https://bugs.kde.org/show_bug.cgi?id=340310 > > > Repository: kwindowsystem > > > Description > ------- > > The idea was to not perform the action if QX11Info reports that its > not the xcb plugin. But this check is not correct as those methods > are not going through QX11Info at all. In addition they pass in either > an xcb connection or XLib display which is totally fine and needed > for example if we want Wayland applications interact with the X11 > world. Also it causes problems for e.g. kdeinit which is not a > Q*Application and thus does not have a QX11Info. > > At the same time fix an incorrect usage of QX11Info::connection > where an xcb_connection_t* is already passed in to the method. > > BUG: 340310 > > > Diffs > ----- > > src/kxmessages.cpp 2e625d29c4fd4a5056d792f565d53dea5e6529fd > > Diff: https://git.reviewboard.kde.org/r/121198/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
