> On Dez. 8, 2014, 2:09 nachm., Sebastian Kügler wrote: > > dataengines/powermanagement/powermanagementengine.cpp, line 74 > > <https://git.reviewboard.kde.org/r/121365/diff/1/?file=332032#file332032line74> > > > > I suppose this change comes from powerdevil itself? (Please check, you > > probably know why you did that change, but it's not immediately obvious to > > me, if you know it's correct, no further action needed of course.)
That was an unrelated change I pushed separately now. > On Dez. 8, 2014, 2:09 nachm., Sebastian Kügler wrote: > > dataengines/powermanagement/powermanagementengine.cpp, line 99 > > <https://git.reviewboard.kde.org/r/121365/diff/1/?file=332032#file332032line99> > > > > can we use compile-time connections here? We recently saw this kind of > > code breaking (especially likely since we're tapping into 3rd party dbus > > APIs here) Unfortunately this isn't supported in QDBusConnection::connect() :/ - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121365/#review71552 ----------------------------------------------------------- On Dez. 6, 2014, 12:48 vorm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121365/ > ----------------------------------------------------------- > > (Updated Dez. 6, 2014, 12:48 vorm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This listens for maximum brightness changes to update the availability > accordingly. It does not, however, monitor for the brightnesscontrols > interface to become available on dbus and I have no idea how that would be > done. > > > Diffs > ----- > > dataengines/powermanagement/powermanagementengine.h 8088209 > dataengines/powermanagement/powermanagementengine.cpp a9020cf > > Diff: https://git.reviewboard.kde.org/r/121365/diff/ > > > Testing > ------- > > Works as before, cannot really test that since I cannot rip out my keyboard. > Please see the other review. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
