----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71751 -----------------------------------------------------------
kcms/access/kaccess.h <https://git.reviewboard.kde.org/r/121424/#comment50029> Why is QAbstractButton needed here? I don't see it used in the header file anywhere. kcms/access/kcmaccess.h <https://git.reviewboard.kde.org/r/121424/#comment50031> I don't see any need for a new configChanged slot that takes a double, all it does is the same thing as the original configChanged. kcms/access/kcmaccess.cpp <https://git.reviewboard.kde.org/r/121424/#comment50030> This should just be removed, you created a QLabel with this text, no need for a commented out line from the old KNumInput api. - Jeremy Whiting On Dec. 10, 2014, 2:31 p.m., Toby Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121424/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2014, 2:31 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-desktop > > > Description > ------- > > [GCI2014]Remove the depencence on KDELibs4Support form KCMAccess > > > Diffs > ----- > > kcms/access/main.cpp 09864fc > kcms/access/kcmaccess.h d3cb40f > kcms/access/kcmaccess.cpp 6c8bc65 > kcms/access/kaccess.h 716bfcf > kcms/access/kaccess.cpp aea6f86 > kcms/access/CMakeLists.txt 64b1cc9 > > Diff: https://git.reviewboard.kde.org/r/121424/diff/ > > > Testing > ------- > > I have ran kcmshell5 kcmaccess, did see no problem. > > > Thanks, > > Toby Chen > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
