> On Dez. 11, 2014, 10:42 vorm., Dmitry Shachnev wrote: > > Ship It! > > Martin Gräßlin wrote: > do you have commit rights or should someone push the change for you?
No, I don't have rights. Actually this is my first contribution to KDE :) So please push it for me (and sorry for useless noise). - Dmitry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121439/#review71787 ----------------------------------------------------------- On Dez. 11, 2014, 8:26 vorm., Dmitry Shachnev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121439/ > ----------------------------------------------------------- > > (Updated Dez. 11, 2014, 8:26 vorm.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: frameworkintegration > > > Description > ------- > > Documentation of KStatusNotifierItem::showMessage() says: > > const QString &icon | icon to be shown to the user > > So we need name of the icon here, not name of the theme. > > > Diffs > ----- > > src/platformtheme/kdeplatformsystemtrayicon.cpp 51f31ad > > Diff: https://git.reviewboard.kde.org/r/121439/diff/ > > > Testing > ------- > > > Thanks, > > Dmitry Shachnev > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
