----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121697/#review72558 -----------------------------------------------------------
src/declarativeimports/plasmacomponents/qmenuitem.h <https://git.reviewboard.kde.org/r/121697/#comment50585> this is missing a connect m_action, enabledChanged, this, enabledChanged - David Edmundson On Dec. 27, 2014, 4:02 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121697/ > ----------------------------------------------------------- > > (Updated Dec. 27, 2014, 4:02 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This forwards the internal QAction's enabled property. > > It's a bit unfornuate that you cannot use QQuickAction (aka QtControls.Action > {}) for "action", only C++ QAction works. > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qmenuitem.h f8629f0 > src/declarativeimports/plasmacomponents/qmenuitem.cpp 1d9076f > > Diff: https://git.reviewboard.kde.org/r/121697/diff/ > > > Testing > ------- > > MenuItem with "enabled" bound to things properly activates and deactivates > the entry. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
