----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121936/#review73551 -----------------------------------------------------------
eh sorry that I didn't notice that you didn't read the property at all. And yes ideally it should go to KWindowSystem. - Martin Gräßlin On Jan. 8, 2015, 10:18 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121936/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 10:18 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: powerdevil > > > Description > ------- > > Before starting the effect check whether it is available. I had to tweak that > check a bit, apparently it was not enough just getting the atom (it would > return something sensible each time) but I also need to check for whether > it's available on the root window. > > This patch is merely to fix the inability to suspend in the > non-compositing/effect disabled case. Eventually I want to be able to use a > new KWindowEffects::isEffectAvailable(KScreenHelperEffect) instead but > unfortunately I wasn't aware of this method until now and so we need to fix > it here until we can use the new frameworks version which is due after the > 5.2 release. > > The effect is changed so it emits fadedOut() when it did not start because it > was unsupported. This way a user can just start the effect and have the > signal fired nonetheless without any additional codepaths and checks outside > of the effect. > > > Diffs > ----- > > daemon/actions/bundled/suspendsession.cpp 9663016 > daemon/kwinkscreenhelpereffect.h cb60b5f > daemon/kwinkscreenhelpereffect.cpp 89652e6 > > Diff: https://git.reviewboard.kde.org/r/121936/diff/ > > > Testing > ------- > > Suspending in both compositing and non-compositing cases works now. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
