> On Gen. 9, 2015, 3:37 p.m., Martin Klapetek wrote: > > applets/systemtray/package/contents/ui/main.qml, lines 116-117 > > <https://git.reviewboard.kde.org/r/121948/diff/1/?file=339308#file339308line116> > > > > I think this comment should to the xml as people/distros wanting to > > customize it will look only at the xml file, not here > > > > So should be explained there what the default value is
for a different default, a distribution would write the default configuration with desktop scripting. now, to see wether this patch is ok, remains to be seen if a layout.js script writing a list of applets keeps working. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121948/#review73605 ----------------------------------------------------------- On Gen. 9, 2015, 3:09 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121948/ > ----------------------------------------------------------- > > (Updated Gen. 9, 2015, 3:09 p.m.) > > > Review request for Plasma. > > > Bugs: 342658 > https://bugs.kde.org/show_bug.cgi?id=342658 > > > Repository: plasma-workspace > > > Description > ------- > > So far, we used to have a hardcoded list of plasmoids to have over there. > While this works this can have some drawbacks (see attached bug). In this > case, it's not possible for muon to appear over there by default (which makes > complete sense) and it's not acceptable to get muon on the default list > because well, it might not be there. > > Another very similar use-case is KTp presence plasmoid. It can't be hardcoded > as it's not even part of plasma, but if you have KTp installed you want it > there, because it's needed for a fluent usage of the suite. > > > Diffs > ----- > > applets/systemtray/package/contents/config/main.xml 5f8c598 > applets/systemtray/package/contents/ui/main.qml 36e31d0 > applets/systemtray/plugin/host.h e8db75c > applets/systemtray/plugin/host.cpp 117c2a0 > > Diff: https://git.reviewboard.kde.org/r/121948/diff/ > > > Testing > ------- > > Removed my config, ran it again, the plasmoids marked as > "X-KDE-PluginInfo-EnabledByDefault=true" and NotificationArea-proof appeared. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
