> On Jan. 27, 2015, 7:27 a.m., Ivan Čukić wrote: > > src/service/ksmserver/KSMServer.cpp, line 72 > > <https://git.reviewboard.kde.org/r/122065/diff/2/?file=345332#file345332line72> > > > > Can you add: > > - checking for the environment variable existence (and using it, if not > > empty) > > - a TODO with a summary of what was talked about here? (multi-head > > problems, the need for session management to be reimplemented in some way > > on waland etc.) > > Martin Gräßlin wrote: > I suggest to ignore the environment variable. > > Martin Gräßlin wrote: > I should also add the reasoning: the env variable is KWin internal and > not public API. We do not guarantee that the env variable is interpreted the > way as it is currently in KWin (in fact the interpretation changed just today > depending on multi-head). Public useable API is only exported on the root > window. > > Thus for external usage I suggest to ignore it.
Ok. Then just a TODO comment, and that's it. - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122065/#review74808 ----------------------------------------------------------- On Jan. 27, 2015, 12:23 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122065/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 12:23 a.m.) > > > Review request for Plasma, Martin Gräßlin and Ivan Čukić. > > > Repository: kactivities > > > Description > ------- > > 1. KWin Interface name is wrong > 2. kactivitymanagerd doesn't listen on ksmserver anymore, thus > subSession{Opened,Closed,CloseCanceled} are not called anymore. It need to > send Started/Stopped event by itself when kwin dbus call returns. > > > Diffs > ----- > > src/service/ksmserver/KSMServer.cpp b5e1467 > src/service/ksmserver/KSMServer_p.h c0f5598 > > Diff: https://git.reviewboard.kde.org/r/122065/diff/ > > > Testing > ------- > > Now starting and stopping activity works properly. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
