----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75695 -----------------------------------------------------------
Ship it! The one thing I'm missing is an indicator for the currently selected year and month, should be exactly the same tinting as the selected day. Otherwise, very nice work. When I implemented the combo-like behaviour, it was really resorting to that solution, yours is much, much nicer indeed. - Sebastian Kügler On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122488/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2015, 8:52 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-framework > > > Description > ------- > > This improves the calendar navigation by providing a "Year overview" showing > all 12 months in a grid, and a "Decade overview" showing the current decade > in a grid. > > A lot of code has just been moved around. The overviews use a QML ListModel > owing to laziness. > > See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that > mouse click effect!) > > > Diffs > ----- > > src/declarativeimports/calendar/calendar.cpp a766acb > src/declarativeimports/calendar/daydata.h 39ac086 > src/declarativeimports/calendar/daysmodel.h ec88837 > src/declarativeimports/calendar/daysmodel.cpp 1a6f454 > src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e > src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e > src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db > src/declarativeimports/calendar/calendar.h ea20bf5 > > Diff: https://git.reviewboard.kde.org/r/122488/diff/ > > > Testing > ------- > > I changed the selection to be persistent during navigation; other than that, > should work as before, with the new overviews. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
