> On mar. 7, 2015, 4:25 p.m., Kai Uwe Broulik wrote: > > https://git.reviewboard.kde.org/r/122632/ sorry for not having it merged yet > > Albert Astals Cid wrote: > Well, your solution is wrong, this is the right one. > > Albert Astals Cid wrote: > Ok, that was a harsh, sorry, let me rephrase, reading that review request > noone gives a reason for removing the duration other than it kind of fixes > the bug and we don't really care much. Since this one really fixes the bug > and is less invasive changing the behaviour i think this one is a better fix. > > Kai Uwe Broulik wrote: > It makes it Consistent with the rest of plasma and the default breeze > window switcher which don't have animated highlights
plasma-workspace/lookandfeel/contents/windowswitcher/WindowSwitcher.qml has a highlightMoveDuration: 250 too - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122850/#review77172 ----------------------------------------------------------- On mar. 7, 2015, 3:40 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122850/ > ----------------------------------------------------------- > > (Updated mar. 7, 2015, 3:40 p.m.) > > > Review request for Plasma. > > > Bugs: 341007 > http://bugs.kde.org/show_bug.cgi?id=341007 > > > Repository: kdeplasma-addons > > > Description > ------- > > Don't animate the highlight when the holder is not visible > > This way it's always at the correct place on first show. > > > Diffs > ----- > > windowswitchers/thumbnails/contents/ui/main.qml f70b3fc > windowswitchers/informative/contents/ui/main.qml e50dee6 > windowswitchers/text/contents/ui/main.qml 79f97c9 > windowswitchers/compact/contents/ui/main.qml c90959d > windowswitchers/IconTabBox.qml 589d3da > > Diff: https://git.reviewboard.kde.org/r/122850/diff/ > > > Testing > ------- > > Did an alt+tab, didn't get dizzy because the tab was going backwards when it > should not. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
