----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122894/#review77271 -----------------------------------------------------------
Ship it! applets/kickoff/package/contents/ui/configGeneral.qml <https://git.reviewboard.kde.org/r/122894/#comment53054> i would find semantically slightly more correct units.smallSpacing*2 instead of gridUnit/2, but that's not really important, just tastes applets/kickoff/package/contents/ui/configGeneral.qml <https://git.reviewboard.kde.org/r/122894/#comment53053> this looks a bit hackish, sure is visually really necessary? - Marco Martin On March 10, 2015, 8:55 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122894/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 8:55 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > This restores the functionality from the 4.x times. The button uses the same > style used in various places, such as lockscreen and display manager, it has > a "Choose" action and a, previously missing, convenient "Clear" action. > > > Diffs > ----- > > applets/kickoff/package/contents/ui/configGeneral.qml 0b6ec33 > > Diff: https://git.reviewboard.kde.org/r/122894/diff/ > > > Testing > ------- > > Choosing an icon works, applying changes the icon, and reset resets it. Is > there a way to set a config back to its defaults? > > > File Attachments > ---------------- > > Config in action > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/6854d475-e5d1-49a0-b335-19a9028a704c__kickofficondialog.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
