> On March 12, 2015, 1:12 p.m., Aleix Pol Gonzalez wrote: > > src/plasma/theme.cpp, line 421 > > <https://git.reviewboard.kde.org/r/122915/diff/1/?file=354535#file354535line421> > > > > If that's the case, then we will need locking, no? > > > > We don't want 2 different threads modifying the class members at the > > same time...
seems things gets called from a different thread once right after being created.. that would make it the case for every single class created from QML i guess? needs more investigation, but this can potentially unveil a deeper problem in QML? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77360 ----------------------------------------------------------- On March 12, 2015, 10:34 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122915/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 10:34 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > rectSaveTimer is used to event compress the save and sync of the > configuration file that is used as a cache of the rectangles of svg items (in > order to avoid svg renderers creation when possible) > there is exactly one situation where it seems to not work: during creation of > svgitems/framesvgitems, insertintorectcache ends up being called by another > thread than the Theme's qobject thread, and that is not allowed. so in this > case > > during normal svg resizes, all goes as before > > > Diffs > ----- > > src/plasma/theme.cpp 18d4ed6 > > Diff: https://git.reviewboard.kde.org/r/122915/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
