----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123079/#review77823 -----------------------------------------------------------
Ship it! Ship It! - Martin Klapetek On March 20, 2015, 5:44 a.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123079/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 5:44 a.m.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > digitalclock: Don't reverse js timezone offset when using to generate utc > from local time. > > > Diffs > ----- > > applets/digital-clock/package/contents/ui/DigitalClock.qml > 1292f730467d43a331d1253a3872d41ebe2d59c1 > > Diff: https://git.reviewboard.kde.org/r/123079/diff/ > > > Testing > ------- > > In this place we are using the offset to calculate utc from the local time. > My timezone is -6 and my getTimezoneOffset is 360. To take my local time and > get utc, we need to add 6 hours, not subtract 6 hours. We could either > subtract the reverse of the js value, or just add it directly. > > My local time in the tooltip has the right time now. All others are also > calculated correctly now. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
