----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123173/#review78176 -----------------------------------------------------------
Ship it! If it works in plasmashell, ship it. - David Edmundson On March 29, 2015, 2:20 p.m., Bernhard Friedreich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123173/ > ----------------------------------------------------------- > > (Updated March 29, 2015, 2:20 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > Commit 1: Fixed codingstyle > Commit 2: Fixed warning "Unable to assign int to QEasingCurve" > Commit 3: Added notification on timer completion (not working yet) > > > Diffs > ----- > > applets/timer/package/contents/ui/TimerDigit.qml > 94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405 > applets/timer/package/contents/ui/timer.qml > 09df67004f07352436a30195fb13c2550f8ebce7 > > Diff: https://git.reviewboard.kde.org/r/123173/diff/ > > > Testing > ------- > > Event is fired when the timer is finished (console.log output works) but the > notification won't show up. > > I get this message on console: Are we the only client? (Both have to be true) > false true > > How can I send a notification from qml (without c++)? Am I on the right track? > > [Edit] Looks like the notification is working if the plasmoid is added > somewhere but not from within plasmawindowed.. any ideas? > > > Thanks, > > Bernhard Friedreich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
