> On April 6, 2015, 5:18 nachm., Mark Gaiser wrote: > > Err, i don't see an error in the vertical before version. The kickoff icon > > simply scales to the new available width, that's how it's supposed to work, > > right? > > > > I'm not 100% sure. A plasma dev will probably jump in and correct me if i'm > > wrong :)
It's a regression compared to plasma 1 and this patch just restores the behaviour from plasma 1. If it uses the available width for it's height, it looks enormous, takes much of the vertical space and is also distracting. With the patch, the button is still using the full width as click area and just limits the height. - Mathias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78570 ----------------------------------------------------------- On April 6, 2015, 11:40 vorm., Mathias Kraus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123271/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 11:40 vorm.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > In vertical panels, the kickoff button is huge. This patch limits the size of > the kickoff button. > > > Diffs > ----- > > applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION > applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb > > Diff: https://git.reviewboard.kde.org/r/123271/diff/ > > > Testing > ------- > > see screenshots > > > File Attachments > ---------------- > > kickoff-horizontal-before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png > kickoff-horizontal-after > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png > kickoff-vertical-before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png > kickoff-vertical-after > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png > > > Thanks, > > Mathias Kraus > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
