-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123280/#review78581
-----------------------------------------------------------


I don't understand the moving the recently used model startup part. 

What's broken about loading it later?

- David Edmundson


On April 6, 2015, 9:35 p.m., Anthony Vital wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123280/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 9:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This does two things:
> - Instantiate the RecentlyUsedModel at startup, otherwise it's not available
> until the History tab is opened and this leads to some mixing in the recent
> apps list/the list not being updated until then.
> - Move the registration of the service handler to the launcher, so that the
> apps launched from the Favorites tab are registered without having to open
> the Applications tab first.
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/core/applicationmodel.cpp 
> 9af58a36d5c3349ad1f2bffd0f7f93eebd99663e 
>   applets/kickoff/core/urlitemlauncher.cpp 
> 58a6c20cec60ede54ea55d927064eaf8af9b4f46 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 
> 15dde962f2321d9b186c9d73246491dc48b398bb 
>   applets/kickoff/package/contents/ui/RecentlyUsedView.qml 
> df25db21db4a6bd764dee3ff8583e2bdc35fe341 
> 
> Diff: https://git.reviewboard.kde.org/r/123280/diff/
> 
> 
> Testing
> -------
> 
> Launched applications from Favorites and Applications tab without opening the 
> History tab first, items are added correctly.
> 
> 
> Thanks,
> 
> Anthony Vital
> 
>

_______________________________________________
Plasma-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to