----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123350/#review78891 -----------------------------------------------------------
applets/kickoff/package/contents/ui/BaseView.qml (line 63) <https://git.reviewboard.kde.org/r/123350/#comment53941> this change seems uneeded; we're using modelIndex fine in the old code, see line 40 in KickoffItem.qml in the old code. (unless maybe that didn't work ?) My understanding is setting the model to a QAIM, internally just creates a VDM anyway. - David Edmundson On April 13, 2015, 11:56 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123350/ > ----------------------------------------------------------- > > (Updated April 13, 2015, 11:56 a.m.) > > > Review request for Plasma. > > > Bugs: 346002 > https://bugs.kde.org/show_bug.cgi?id=346002 > > > Repository: plasma-desktop > > > Description > ------- > > Patch by Konrad Materka > adress mounting of removable devices by kickoff > > > Diffs > ----- > > applets/kickoff/core/systemmodel.cpp 005cfb2 > applets/kickoff/package/contents/ui/BaseView.qml c74db68 > applets/kickoff/package/contents/ui/KickoffItem.qml f48d53b > > Diff: https://git.reviewboard.kde.org/r/123350/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
