> On April 15, 2015, 8:09 p.m., David Edmundson wrote: > > Ship It!
Do you have commit access? can you put it in the 5.3 branch too - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123351/#review78991 ----------------------------------------------------------- On April 13, 2015, 1:21 p.m., David Kahles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123351/ > ----------------------------------------------------------- > > (Updated April 13, 2015, 1:21 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-workspace > > > Description > ------- > > With the last comment, the login promt was displayed on every screen to > fix a multiscreen issue. But this introduces a bug when two monitors > are attached and the screens are configured to overlap and be mirrored > on both monitors. > This can happen when xorg is autoconfigured (kscreen isn't loaded in > sddm). In this case, two loginbars are created (because there are two > screens) but are both displayed on both monitors (because the > screens are overlapping). > > With this change, there is only one loginbar on the primary monitor, > so this will not be a problem anymore. This is also the behavior of > other sddm themes, as well as GDM and Windows. > > SDDM-BUG: #265 (https://github.com/sddm/sddm/issues/265, it's fixed by the > last change to the login promt, but the change introduced this bug) > > > Diffs > ----- > > lookandfeel/contents/loginmanager/Main.qml > 6d24e7f842c5f379946102c533fe57272b1e026b > lookandfeel/contents/loginmanager/README.txt > 0c5ed9f7fa27a29367ea741abedce3ddac74c549 > lookandfeel/contents/loginmanager/dummydata/screenModel.qml > 981f364886102d833cac0f12ee173eb725cd45f5 > > Diff: https://git.reviewboard.kde.org/r/123351/diff/ > > > Testing > ------- > > Tested with one monitor (xorg autoconfiguration) and two monitors in the > following configurations: > - xorg autoconfiguration > - both monitors side by side > - configuration to get a behavior similar to this: > https://cloud.githubusercontent.com/assets/48491/7106740/1cf262f2-e14c-11e4-84fa-1bf5dc6a2dfb.jpg > (This is the mentioned bug) > This still draws the background multiple times, which could be overlapping > depending on the order of the screens, which is ugly but usable. (Only in > this configuration) > A fix for this would require to sort out overlapping screens and choose the > biggest one in sddm, but this gets complicated if one screens doesn't contain > an other one completely, > so I don't know how to fix this. > > > Thanks, > > David Kahles > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
