> On April 18, 2015, 7:50 a.m., Martin Gräßlin wrote: > > applets/pager/plugin/pager.h, line 144 > > <https://git.reviewboard.kde.org/r/123411/diff/1/?file=361959#file361959line144> > > > > m_rows seems not to be initialized if m_isX11 is false
I tried to change this in patch revision #2. I hope I'm doing this correctly in ReviewBoard. - Nerdopolis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123411/#review79155 ----------------------------------------------------------- On April 22, 2015, 12:05 a.m., Nerdopolis Turfwalker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123411/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 12:05 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing > in Wayland > > > Diffs > ----- > > applets/pager/plugin/pager.h 78d461d2554e4885721da3d2eff82151c97f9305 > applets/pager/plugin/pager.cpp 22c6ca2747f297dc3d37d02b46cb33196e64b1e0 > > Diff: https://git.reviewboard.kde.org/r/123411/diff/ > > > Testing > ------- > > Ran plasmoidviewer -a org.kde.plasma.pager in with QT_QPA_PLATFORM=wayland > got no crash from plasmoid viewer. > > Started an Xephyr session, set QT_QPA_PLATFORM=xcb and DISPLAY=:1, started > kwin_x11, and then plasmoidviewer -a org.kde.plasma.pager and had full > functionality. > > > Thanks, > > Nerdopolis Turfwalker > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
