> On May 8, 2015, 9:16 p.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/loginmanager/Main.qml, line 235 > > <https://git.reviewboard.kde.org/r/123688/diff/1/?file=367729#file367729line235> > > > > I was wondering whether "sddm" just has a "busy" property that we could > > hook to the button's enabled property and have bindings do the magic rather > > than manual book keeping of the enabled state
No, unfortunately there is no such property: https://github.com/sddm/sddm/blob/master/docs/THEMING.md > On May 8, 2015, 9:16 p.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/loginmanager/Main.qml, line 93 > > <https://git.reviewboard.kde.org/r/123688/diff/1/?file=367729#file367729line93> > > > > The timer stops automatically because it's not repeating Yes, but this function is needed though, imagine this: - A user tries to login, but the login fails -> The timer gets started - The user changes the password and logs in again, before the timer expired, but login fails aggain. -> The notification would be cleared when the timer from the first login expires, e.g. 1 second after this login, so we need to stop the timer before the next login happens. Thanks anyway, I thought about it again, and got rid of this function by using Timer.restart() signal and clearing the notification directly from the startLogin() function. > On May 8, 2015, 9:16 p.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/loginmanager/Main.qml, lines 99-100 > > <https://git.reviewboard.kde.org/r/123688/diff/1/?file=367729#file367729line99> > > > > Those are default Right, I removed the "repeat: false" from the other timer too. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123688/#review80102 ----------------------------------------------------------- On May 8, 2015, 6:48 p.m., David Kahles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123688/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 6:48 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Disables the button and the passwordfield while the password check is > running and hides the "Login Failed" message after 3 seconds. > > > Diffs > ----- > > lookandfeel/contents/loginmanager/Main.qml > 528f9b4e43ee6b8636ca1c816d5bad556bede871 > > Diff: https://git.reviewboard.kde.org/r/123688/diff/ > > > Testing > ------- > > Login and failed login are working as expected. > Tested in qmlscene and on two computers running Archlinux. > > > Thanks, > > David Kahles > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
