----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123836/ -----------------------------------------------------------
(Updated May 18, 2015, 3:34 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes ------- Submitted with commit bbf19c13ee61fe0f09263d2fdd40207a71dca6fd by Martin Klapetek to branch master. Repository: knotifications Description ------- The NotifyByPopup plugin is accessing QApplication::desktop() in constructor which Qt does not like when that happens on non-GUI thread and asserts. So this moves that code only when actually needed plus it checks first if the code is run in non-GUI thread and does nothing if it's not. This is only for the popup fallback notifications, normal notifications work just fine. Diffs ----- src/notifybypopup.cpp 2f84ab0 Diff: https://git.reviewboard.kde.org/r/123836/diff/ Testing ------- Tested with both multi-threaded and single-threaded codes. Thanks, Martin Klapetek
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
