> On June 29, 2015, 7:57 a.m., David Edmundson wrote: > > Was this causing an error?
Yes, most of the applets (see my other patches) were broken after my update this week-end. I didn't update in a while previously. I noted that the applets were inconsistent some using import "foo.js" (all broken for me) and some using import "../code/foo.js" (all working for me). Because of the inconsistency I went on making it consistent again picking the one which worked in practice. Note I'm testing with Qt 5.5 on my end. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/#review81844 ----------------------------------------------------------- On June 29, 2015, 7:15 a.m., Kevin Ottens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124204/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 7:15 a.m.) > > > Review request for Plasma. > > > Repository: bluedevil > > > Description > ------- > > Use proper relative paths to import js code > > > Diffs > ----- > > src/applet/package/contents/ui/BluetoothApplet.qml > 4e8b9648983edd2c8db242515464ae22d1e6fbe6 > src/applet/package/contents/ui/CompactRepresentation.qml > 7085a7ec82fa88cb2d8e1a58847215845f3d5658 > > Diff: https://git.reviewboard.kde.org/r/124204/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Ottens > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
