> On July 6, 2015, 12:51 p.m., Kai Uwe Broulik wrote: > > shell/panelview.cpp, line 348 > > <https://git.reviewboard.kde.org/r/124267/diff/1/?file=383465#file383465line348> > > > > if (!(foo || bar)) makes my head explode
yeah, seems not just overly complicated but also completely wrong. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124267/#review82123 ----------------------------------------------------------- On July 6, 2015, 12:36 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124267/ > ----------------------------------------------------------- > > (Updated July 6, 2015, 12:36 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Use KWin to lower/raiser panel in windows can cover mode with edge activation > like autohide does. > > This means if you have a maxmised menu you can still open the panel by moving > the mouse to the bottom of the screen > > -- > Requires new incoming kwin patch. > > > Diffs > ----- > > shell/panelview.h a41f9883da90bf661f4963e3b2e60a1dc49ab08c > shell/panelview.cpp b94673d72fa4b226613338c31eb2300f4372b5d2 > > Diff: https://git.reviewboard.kde.org/r/124267/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel