> On July 8, 2015, 1:05 p.m., Aleix Pol Gonzalez wrote: > > +1 LGTM. > > > > Still, this is a workaround... ksmserver shouldn't be using X11 after all. > > Or there's a good reason?
yes, there are good reasons. It is the X11 session manager. This is a functionality which is very X specific and doesn't make sense in a Wayland world. So ksmserver looks like a candidate for never being ported. Parts of it will have to be split out into other parts (e.g. session startup, screenlocker), but the core functionality - the X11 session manager - will always be X11 specific and stay in ksmserver. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124292/#review82217 ----------------------------------------------------------- On July 8, 2015, 11:31 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124292/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 11:31 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Ksmserver is very X11 specific, so let's enforce the xcb plugin. This > allows to start ksmserver also on a Wayland session for compatibility. > > > Diffs > ----- > > ksmserver/main.cpp eaceb5a6f069cf621703aece22f66d2aa645e10f > > Diff: https://git.reviewboard.kde.org/r/124292/diff/ > > > Testing > ------- > > only compile tested so far > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
