----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82640 -----------------------------------------------------------
Cool. Thanks for this. FYI we're hoping to drop the ConsoleKit 1 support in Plasma 5.5; so that should hopefully simplify this moving forwards as we end up with a single API and just loading the same object on potentially two different paths. daemon/powerdevilpolicyagent.h (line 132) <https://git.reviewboard.kde.org/r/124388/#comment56993> I don't think we need a new variable; it's basically acting like the logind one so we can re-use it. What I like then like is then we can drop the multiple setup and instead pass the QDBusInterface which would be IMHO cleaner. - David Edmundson On July 19, 2015, 9:22 a.m., Eric Koegel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124388/ > ----------------------------------------------------------- > > (Updated July 19, 2015, 9:22 a.m.) > > > Review request for Plasma and Solid. > > > Repository: powerdevil > > > Description > ------- > > Internally, it uses the login1 interface with ConsoleKit2 since they share > identical DBUS calls. It also changes the setupSystemdInhibition to > setupSeatManagerInhibition so that the login1 and ConsoleKit2 inhibit calls > to minimize code duplication. > > This patch doesn't modify the build system to keep it small. A future patch > can be added to use ConsoleKit2 on BSD systems as well. > > ConsoleKit2's suspend/hibernate/inhibit DBUS API is documented at: > http://consolekit2.github.io/ConsoleKit2/#Manager > > > Diffs > ----- > > daemon/backends/upower/powerdevilupowerbackend.h 1c4dd59 > daemon/backends/upower/powerdevilupowerbackend.cpp 87b9cc7 > daemon/powerdevilpolicyagent.h ef41ad7 > daemon/powerdevilpolicyagent.cpp 9210a06 > > Diff: https://git.reviewboard.kde.org/r/124388/diff/ > > > Testing > ------- > > Built powerdevil with patch and pkla files on a Gentoo system with OpenRC. > Before patch there was no suspend option, after there was and clicking it > resulted in the system properly suspending. > > > Thanks, > > Eric Koegel > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
