> On Juli 28, 2015, 12:41 nachm., David Edmundson wrote: > > src/declarativeimports/calendar/qml/MonthView.qml, line 235 > > <https://git.reviewboard.kde.org/r/124507/diff/1/?file=388383#file388383line235> > > > > I think it's better too have the Stack.onStatusChanged here. > > > > All stackview code is in this class, and all other setting of scale > > happens in here. > > > > If you disagree, leave it as it is though. I don't really mind.
I have three places where I create a DaysCalendar, so I would have to copy that code a lot. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124507/#review83088 ----------------------------------------------------------- On Juli 28, 2015, 12:23 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124507/ > ----------------------------------------------------------- > > (Updated Juli 28, 2015, 12:23 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-framework > > > Description > ------- > > Now you can pinch to zoom out in the calendar. Why? Because we can! > > https://www.youtube.com/watch?v=i8a-MPyzMOw > > > Diffs > ----- > > src/declarativeimports/calendar/qml/DaysCalendar.qml 35a1e20 > src/declarativeimports/calendar/qml/MonthView.qml 57ac59a > > Diff: https://git.reviewboard.kde.org/r/124507/diff/ > > > Testing > ------- > > Works. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
