On Wed, Jul 29, 2015 at 12:35 AM, Eike Hein <[email protected]> wrote: > > > On 07/28/2015 04:42 PM, David Edmundson wrote: > > Lets make sure we go through reviews please. > > Sure. The preliminary code is in the hein/appdash branches > of plasma-desktop and kdeplasma-addons (you need both), and > it's called "Application Dashboard" in the widget list. > > Cool, ship it.
Two things to fixup. +void FullScreenWindow::updateTheme() half the code here is never executed + const QChar &first = appEntry->name().at(0).toUpper(); QString::at() will qFatal() if out of bounds ; it's not unfeasible to have a dodgy .desktop entry without a name. > The various notes on this Marco and you got in IRC discussions > etc. apply :) > > There's a few remaining issues I still need to address, in > particular mouse wheel support for complex categorized views. > > > Cheers, > Eike > _______________________________________________ > Plasma-devel mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/plasma-devel >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
