----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124933/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-workspace Description ------- This fixes type errors shown on startup: TypeError: Cannot read property 'showPassword' of undefined TypeError: Cannot read property 'ButtonLabel' of undefined REVIEW: 124931 [screenlocker] Try to load faster by using more loaders All UI is put into a loader to get the actual lock screen loaded faster. This gets the creation of two views down to about < 600 msec from before around 1.8 sec. The initial startup time is extremely important to ensure the screen is properly locked when going to suspend. Diffs ----- ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c lookandfeel/contents/lockscreen/ChangeSession.qml PRE-CREATION lookandfeel/contents/lockscreen/LockOsd.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a001efc2ffab2d78388e3a619d0de93f1758 lookandfeel/contents/lockscreen/MainBlock.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124933/diff/ Testing ------- the OSD is not anchored correctly any more. Thanks, Martin Gräßlin
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
