> On Sept. 10, 2015, 6:33 a.m., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, lines 433-434 > > <https://git.reviewboard.kde.org/r/125120/diff/1/?file=402386#file402386line433> > > > > on X11 the time might also come from the property. > > Marco Martin wrote: > for Eike: is the custom animation time passed in the effect still needed? > (iirc it was used in yakuake) > > Eike Hein wrote: > Yakuake still exposes this as a GUI setting. Personally I wouldn't mind > removing it too much. I know some users do use it, but most of them predate > the redesign of the slide effect to include fading. > > Marco Martin wrote: > so, will give few days to think about.., then how you guys decide to > include them, I can add those properties in the kwayland protocol as well > (while would still be not exposed in kwindoweffect one could still use > kwayland by hand)
after discussion in the hangout, i'll not add them for now, but they can be added in a next release in a compatible way if needed for how the protocol is designed - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/#review85083 ----------------------------------------------------------- On Sept. 10, 2015, 11:03 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125120/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2015, 11:03 a.m.) > > > Review request for kwin, Plasma and Eike Hein. > > > Repository: kwin > > > Description > ------- > > take and apply thhe informations from the wayland slide protocol in the > sliding popups effect > > > Diffs > ----- > > effects/slidingpopups/slidingpopups.h ac3cf10 > effects/slidingpopups/slidingpopups.cpp f6d9ec5 > > Diff: https://git.reviewboard.kde.org/r/125120/diff/ > > > Testing > ------- > > slide to appear works, slide out to disappear doesn't. > > the second time a popup is opened, kwin crashes and an assert is hit > > kwin_wayland: > /home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: > KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, > double) const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() > && y1 >= top() && y2 <= bottom()' failed. > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
