> On Oct. 9, 2015, 10:40 a.m., Kai Uwe Broulik wrote:
> > Finally new sticky notes \o/
> > 
> > I'm a bit sad about the loss of shadows around widgets. Also, I liked 
> > Plasma's configure icon much better and wish that one was put into the 
> > Breeze theme rather than vice-versa as it is now.
> 
> Martin Klapetek wrote:
>     I agree with the icon. I feel like it's changing every release or so.
> 
> Uri Herrera wrote:
>     Yeah, the shadows.. I was intending on having the shadows the same way 
> they're in the actual windows but I find it to be really hard to get it 
> right. The super heavy shadow that was being used was a left-over from the 
> Oxygen and Air themes. It is still using a shadow of course just not as heavy.
>     
>     I added hamburger menu icon to the icon theme a while back.
> 
> Martin Klapetek wrote:
>     > I added hamburger menu icon to the icon theme a while back.
>     
>     The one on the notes applet. In the "before" screenshot, it's the two 
> horizontal lines with circles, the "after" has a window of some sort. Before 
> it was a wrench icon. I do agree with Kai that the 
> horizontal-bars-with-circly-things looks better as a settings icon, the 
> window of some sort is not that much telling.
> 
> Uri Herrera wrote:
>     That icon is the _literal_ representation of the window that it opens.
>     
>     ![](http://i.imgur.com/axfxffD.png)
> 
> Martin Klapetek wrote:
>     Yeah I get that. But I don't want to keep remembering the looks of 
> windows to associate them with an icon/action (not mentioning the config 
> window looks might change and that would change the icon (again) I presume). 
> It's kind of like the "save" button all of a sudden getting a /literal/ looks 
> of the save dialog instead of that floppy that everyone is so used to.
> 
> Uri Herrera wrote:
>     You did do that whenver you started using software that had the floppy as 
> the save icon. You had to remember "this floppy icon means save" and now 
> you're used to it. It's the same.
> 
> Uri Herrera wrote:
>     Also the icon (the one with sliders) is for 1) Start menu categories 2) a 
> somewhat small version of System Settings but not really and 3) a workaround 
> for applications whose toolbar uses a category icon (the actual use) -
> 
> Martin Klapetek wrote:
>     But then again - this icon is being changed for the third time in 5 
> releases. By the time me and all our users got this association into 
> mine/their minds, there comes the need to reassociate. This time with a 
> window. Which I still think makes no sense. Especially since the config 
> dialog is very likely /not/ going to look like this on Plasma Mobile. Hence 
> the generic/symbolic representation of the action seems better fit rather 
> than a /literal/ representation of the window.
> 
> andreas kainz wrote:
>     But Uri use the config icon instead of the shortcut icon (old one) and 
> about 3 changes in 5 releases. sorry we work heavy on the icons.
> 
> Uri Herrera wrote:
>     That's as simple to fix as Plasma mobile using a different icon and me 
> making it. In fact it wasn't changed, it was missing. The one I made first 
> was the one with the sliders (for the toolbars) and that was the one used 
> when the current Breeze theme was made because it was the only icon for that 
> action (configuration). The version before that was using assets from Oxygen 
> and Air.
>     
>     And I do understand what you mean, but, it's the same whenever we learn 
> anything new. Always, we have to get used to it first. I (and Andreas of 
> course) have changed other icons too over the course of the last year. 
> Haven't seen that as a problem, setback, issue or cause of confusion for 
> people using Breeze.
> 
> andreas kainz wrote:
>     and of corse most icons were changed cause of a bug report
> 
> Martin Klapetek wrote:
>     > fix as Plasma mobile using a different icon and me making it
>     
>     Which is precisely what I would like to avoid in our software. There are 
> just too many "configure" icons around. But oh well, why do I bother.
> 
> Uri Herrera wrote:
>     But that's exactly what you should be doing, use icons depending on the 
> context, just because an icon "works" doesn't mean, like at all, that it 
> should be used everywhere, regardless of whether is an 
> action/status/category, that's exactly why I had (and still have) workaround 
> icons in the theme. Because icons were not used properly and were used just 
> becasue "they worked". And come on now there's only 2 configure icons... 
> that's not too many.
> 
> andreas kainz wrote:
>     Uri we have 3 config icons: configure (configure), applications-system 
> (shortcuts) and application-menu (burger menu).

applications-system is not a configure icon. The icon is a workaround for 
applications whose toolbar uses a category icon. Like Dolphin. Check the 32px 
one, the icon is for start menus.


- Uri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125568/#review86531
-----------------------------------------------------------


On Oct. 9, 2015, 8:18 p.m., Uri Herrera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125568/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 8:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> SVG elements done from scratch, reused only a small portion of the existing 
> files. Colors now match Breeze colorscheme. Buttons now match widget style. 
> Icons in the system tray are taken from the icon theme. Icons in Kickoff are 
> not monochromatic as only 16px and 22px icons are monochrome in Breeze. 
> Better padding overall for elements. New visual for both task manager widgets 
> that matches the states of the buttons. Checkboxes, radio buttons, sliders 
> and scrollbars now have the colors used in the Breeze colorscheme.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://git.reviewboard.kde.org/r/125568/diff/
> 
> 
> Testing
> -------
> 
> ![Before](http://i.imgur.com/Cz2JNee.png)
> ![After](http://i.imgur.com/hiZlyrb.png)
> 
> ![Elements after](http://i.imgur.com/uMFsMzp.png)
> ![Elements before](http://i.imgur.com/pIs1CZ2.png)
> 
> 
> Thanks,
> 
> Uri Herrera
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to