----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125014/#review86809 -----------------------------------------------------------
Ship it! All for it even tough i think i would prefer having the version bump associated to using new C++ api as well, so that we are sure on 5.4 it wouldn't build, not silently fail - Marco Martin On Oct. 13, 2015, 2:28 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125014/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 2:28 p.m.) > > > Review request for Plasma. > > > Bugs: 352022 > https://bugs.kde.org/show_bug.cgi?id=352022 > > > Repository: plasma-workspace > > > Description > ------- > > This requires bumping the version to Qt5.5 to use the new API > > BUG: 352022 > > > Diffs > ----- > > CMakeLists.txt 4fdcf1a82feae406d6d216dc7bb662b0622f1fff > wallpapers/image/imagepackage/contents/ui/main.qml > 16ba43d9b57d69ee6f5a0c4d93209a4a0f125dd5 > > Diff: https://git.reviewboard.kde.org/r/125014/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
