----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125878/ -----------------------------------------------------------
Review request for Plasma, David Edmundson and David Faure. Summary (updated) ----------------- fix lost QuickViewSharedEngine initialSize on initializing Repository: kdeclarative Description (updated) ------- After my commit 1c3f42afe17cc090372eaf45647d71495de12c19, view's initialiSize value is lost (remaining 0,0 in spite of item's size). It should be set by item's size for some reusing purpose (with initialSize() getter) Sorry again my bad commit :( Diffs ----- Diff: https://git.reviewboard.kde.org/r/125878/diff/ Testing (updated) ------- build and run test kenya888@xps13 ~/devel/kf5/build/frameworks/kdeclarative $ ninja test [1/1] Running tests... Test project /home/kenya888/devel/kf5/build/frameworks/kdeclarative Start 1: fullmodelaccesstest 1/2 Test #1: fullmodelaccesstest .............. Passed 0.05 sec Start 2: quickviewsharedengine 2/2 Test #2: quickviewsharedengine ............ Passed 0.39 sec 100% tests passed, 0 tests failed out of 2 Total Test time (real) = 0.44 sec Thanks, Takahiro Hashimoto
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
