> On Nov. 7, 2015, 1:48 p.m., Sebastian Kügler wrote:
> > kcms/formats/kcmformats.cpp, line 124
> > <https://git.reviewboard.kde.org/r/125984/diff/1/?file=415684#file415684line124>
> >
> >     spaces around the comparison operator, please.

OK, will correct.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125984/#review88137
-----------------------------------------------------------


On Nov. 7, 2015, 1:14 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125984/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2015, 1:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 354984
>     https://bugs.kde.org/show_bug.cgi?id=354984
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> See the referenced bug.  The special locale value "C" needs to be written out 
> as simply that and not with an encoding suffix added, otherwise the resulting 
> value is not accepted by the locale system.
> 
> 
> Diffs
> -----
> 
>   kcms/formats/kcmformats.cpp ea9dece 
> 
> Diff: https://git.reviewboard.kde.org/r/125984/diff/
> 
> 
> Testing
> -------
> 
> Built plasma-desktop with these changes, reset 'kcmshell5 formats' settings, 
> checked correct operation of desktop and of CLI and GUI applications.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to