----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125990/#review88405 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Nov. 15, 2015, 3:06 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125990/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2015, 3:06 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > QStandardPaths doesn't add a trailing slash, nor does > PLASMA_RELATIVE_DATA_INSTALL_DIR have a leading slash. Also, apparently we > need a structure also for uninstall but then we can remove the setPath > because we tell that to uninstall... > > Not sure if we're doing something wrong to begin with here, though. > > > Diffs > ----- > > components/shellprivate/widgetexplorer/widgetexplorer.cpp 0922c18 > > Diff: https://git.reviewboard.kde.org/r/125990/diff/ > > > Testing > ------- > > Works now. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel