----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126089/#review88477 -----------------------------------------------------------
There's a ColorButton in kquickcontrols. Also what's up with those custom TextField controls and all? themeexplorer/package/contents/ui/ColorEditor.qml (line 95) <https://git.reviewboard.kde.org/r/126089/#comment60616> Doesn't "Dialog" do that automatically? themeexplorer/package/contents/ui/ColorEditor.qml (line 97) <https://git.reviewboard.kde.org/r/126089/#comment60617> I think if you made the ColumnLayout the contentItem the Dialog would deduce window sizing automatically from it themeexplorer/package/contents/ui/ColorEditor.qml (lines 189 - 192) <https://git.reviewboard.kde.org/r/126089/#comment60618> You could just make the GridLayout child of the ScrollView themeexplorer/package/contents/ui/ColorEditor.qml (line 198) <https://git.reviewboard.kde.org/r/126089/#comment60619> whitespace themeexplorer/package/contents/ui/ColorEditor.qml (lines 326 - 329) <https://git.reviewboard.kde.org/r/126089/#comment60620> Does keyboard navigation work with that still? ie. return/escape? Also set "isDefault: true" for the default button themeexplorer/package/contents/ui/MetadataEditor.qml (line 39) <https://git.reviewboard.kde.org/r/126089/#comment60621> .forceActiveFocus() ? themeexplorer/src/thememodel.cpp (line 296) <https://git.reviewboard.kde.org/r/126089/#comment60622> Should probably be configurable somewhere - Kai Uwe Broulik On Nov. 16, 2015, 2:37 nachm., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126089/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 2:37 nachm.) > > > Review request for Plasma. > > > Repository: plasma-sdk > > > Description > ------- > > * add a metadata editor functionality that allows to create a theme based > upon the default one and edit some of the metadata afterwards > > * add a graphical editor for the color file that has a little preview with > fake widgets to give an idea how the colors will look > > > Diffs > ----- > > themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION > themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION > themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION > themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION > themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION > themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION > themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION > themeexplorer/package/contents/ui/main.qml af61c39 > themeexplorer/src/CMakeLists.txt c971784 > themeexplorer/src/coloreditor.h PRE-CREATION > themeexplorer/src/coloreditor.cpp PRE-CREATION > themeexplorer/src/main.cpp f2ec4a2 > themeexplorer/src/themelistmodel.h 3ae6eb4 > themeexplorer/src/themelistmodel.cpp 32a6fd4 > themeexplorer/src/thememodel.h 18e404d > themeexplorer/src/thememodel.cpp 5366a7e > > Diff: https://git.reviewboard.kde.org/r/126089/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > snapshot18.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png > snapshot17.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
