> On Oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to you > LC_DATE is only for the formatting and should be using LANG&friends, right? > Why not fix it upstream then? > > Martin Klapetek wrote: > I don't claim it's a bug as I simply don't know if it's correct behavior > or not, just that the way it works does not suit our intended use case, > because we encourage our users to mess with LC_* variables through the > Formats KCM, which makes it prone to mixed configurations like LC_DATE=cs_CZ > and LANG=en_US. > > But nevertheless a) David Edmundson has a patch in the works so let's see > if they think it's a bug and b) we'd need something for the meantime anyway. > > David Edmundson wrote: > Just uploaded: https://codereview.qt-project.org/139295 > > Martin Klapetek wrote: > Given the Qt patch was rejected, I'll ship this if noone objects.
+1 - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87617 ----------------------------------------------------------- On Oct. 20, 2015, 7:04 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125705/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2015, 7:04 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Bugs: 353715 > http://bugs.kde.org/show_bug.cgi?id=353715 > > > Repository: plasma-framework > > > Description > ------- > > Simple QDate::longMonthName won't do the job as it > will return the month name using LC_DATE locale which is used > for date formatting etc. So for example, in en_US locale > and cs_CZ LC_DATE, it would return Czech month names while > it should return English ones. So here we force the LANG > locale and take the month name from that. > > > Diffs > ----- > > src/declarativeimports/calendar/calendar.cpp 67a08e5 > > Diff: https://git.reviewboard.kde.org/r/125705/diff/ > > > Testing > ------- > > LC_DATE=cs_CZ > LANG=en_US > > Month names in calendar applet are now english. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
