----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ -----------------------------------------------------------
(Updated Dec. 21, 2015, 8:39 a.m.) Review request for Plasma, Ashish Bansal and Bhushan Shah. Repository: plasma-mediacenter Description ------- Implemented it like the other datasources. Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList. After the image is fetched, gotImage emits the signal mediaUpdated (from mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel. Diffs (updated) ----- libs/mediacenter/medialibrary.h 45744c1 libs/mediacenter/lastfmimagefetcher.cpp e005077 libs/mediacenter/lastfmimagefetcher.h ecff37e libs/mediacenter/CMakeLists.txt 5a13449 datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION datasources/lastfm/CMakeLists.txt PRE-CREATION datasources/CMakeLists.txt a7171b7 autotests/lastfmimagefetchertest.cpp abb3fd6 autotests/lastfmimagefetchertest.h eb7cb29 autotests/CMakeLists.txt 04ba1c3 libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe Diff: https://git.reviewboard.kde.org/r/125993/diff/ Testing (updated) ------- Builds 100%. The Audio Scrobbler API works as expected. Images are fetched. Problem: The fetched images are not displayed on the app UI however. NOTE: This is just for testing purposes. Hence kept the comments and debugs. Thanks, Aditya Dev Sharma
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
