> On Dec. 22, 2015, 4:35 p.m., Aleix Pol Gonzalez wrote: > > src/declarativeimports/core/iconitem.cpp, line 254 > > <https://git.reviewboard.kde.org/r/126466/diff/1-2/?file=425194#file425194line254> > > > > Are you sure it is a good idea to load the pixmap as we're rendering? > > This will have quite some disk IO (icon look-up, read and rendering if an > > svg).
No, I don't like this either. Let's call it a stab at this to find out if it's what David had in mind. - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89937 ----------------------------------------------------------- On Dec. 22, 2015, 4:32 p.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126466/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 4:32 p.m.) > > > Review request for Plasma and David Edmundson. > > > Bugs: 345545 > http://bugs.kde.org/show_bug.cgi?id=345545 > > > Repository: plasma-framework > > > Description > ------- > > This timer seems to exist purely to delay loading the pixmap for the purpose > of "hey, maybe it will work later ..." when it's not actually needed thanks > to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and > fixes various icon flicker around Plasma, in particular in the Task Manager: > When swapping out a launcher delegate for a task delegate, or when swapping > out delegates during virtual desktop switches. > > > Diffs > ----- > > src/declarativeimports/core/iconitem.h 3abef40 > src/declarativeimports/core/iconitem.cpp bada940 > > Diff: https://git.reviewboard.kde.org/r/126466/diff/ > > > Testing > ------- > > > Thanks, > > Eike Hein > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel