----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/#review90209 -----------------------------------------------------------
I don't really like how this is going to decreaes the load time for an incredibly niche feature, but in general it's fine. applets/kickoff/package/contents/ui/FullRepresentation.qml (line 65) <https://git.reviewboard.kde.org/r/126544/#comment61758> why? if were we to do this it should only do it if that tab is currently open. and given it won't work this is just wasted code. - David Edmundson On Dec. 28, 2015, 2:01 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126544/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 2:01 p.m.) > > > Review request for Plasma, KDE Usability and Eike Hein. > > > Bugs: 347633 > https://bugs.kde.org/show_bug.cgi?id=347633 > > > Repository: plasma-desktop > > > Description > ------- > > This hides the "History" tab if it is empty. > > This can permanently happen if you use disable tracking in activity settings > or administrative means. > > > Diffs > ----- > > applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf > applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 > applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 > > Diff: https://git.reviewboard.kde.org/r/126544/diff/ > > > Testing > ------- > > Button comes and goes as I add and remove history entries. > > When I clear the history, it switches to the Favorites view so you don't end > up with a broken view. > > It doesn't seem to track application launches through Kickoff but I think > this is unrelated. > > > File Attachments > ---------------- > > No history tab > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
