> On Ян. 7, 2016, 5:36 преди обяд, Martin Klapetek wrote: > > No. > > > > I'm fine with disabling the first animation. Post a separate patch > > for that and that only. > > > > Any configuration issues that are left need to be identified > > and fixed, not by reverting and moving things back again. > > Anthony Fieroni wrote: > https://youtu.be/kavjfrRny9I > Video, flying with first test, see configuration. > Test mine, please, revert 126408. > > Martin Klapetek wrote: > This is how much it takes to fix the config issue: > > @@ -39,8 +39,10 @@ QtControls.GroupBox { > > onEnabledChanged: { > if (!enabled) { > - selectedPosition = NotificationsHelper.Default > + positionRadios.current = null > } > + > + selectedPosition = NotificationsHelper.Default > } > > PlasmaCore.Svg { > > > > ...without any reverting and probably faster than > it took you to make and upload the video. > > Again, I will accept only patch that disables the > first animation. There is no need for a revert. > > Anthony Fieroni wrote: > Without video can't see it, first of all. I'm not providing a patch till > this one is removed. > > Martin Klapetek wrote: > That's fine, I have a patch ready for that.
Is patch already works, to discard review? - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126658/#review90725 ----------------------------------------------------------- On Ян. 7, 2016, 5:41 преди обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126658/ > ----------------------------------------------------------- > > (Updated Ян. 7, 2016, 5:41 преди обяд) > > > Review request for Plasma, David Edmundson, Marco Martin, and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > Review 126408 completely same flying and configurations issues > > > Diffs > ----- > > applets/notifications/plugin/notificationshelper.cpp 15b4479 > applets/notifications/package/contents/ui/configNotifications.qml 95a8e59 > applets/notifications/package/contents/ui/Notifications.qml f479a65 > applets/notifications/lib/notificationsapplet.h 5b262f1 > applets/notifications/lib/notificationsapplet.cpp 891cdb0 > applets/notifications/plugin/notificationshelper.h 860a2da > applets/notifications/package/contents/ui/ScreenPositionSelector.qml > efff648 > > Diff: https://git.reviewboard.kde.org/r/126658/diff/ > > > Testing > ------- > > My code works *correctly*, revert patch from 126408 - configurations issues. > Qt 5.5.1, libxcb 1.11.1 Arch Linux > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
