----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91445 -----------------------------------------------------------
Good idea and looks good (IMHO). CMakeLists.txt (line 2) <https://git.reviewboard.kde.org/r/126843/#comment62505> out of interest: why is the version raise required? CMakeLists.txt (lines 18 - 22) <https://git.reviewboard.kde.org/r/126843/#comment62504> on syntax: else and endif don't need to repeat the condition any more. Also we tend to use the lower case variants nowadays. on the feature: maybe better use add_feature_info and add it to the feature list as a required one. - Martin Gräßlin On Jan. 22, 2016, 3:58 p.m., Armin K. wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126843/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 3:58 p.m.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: kwallet-pam > > > Description > ------- > > Currently, kwallet-pam is only usable when used in combination with plasma5, > becaue the code that connects PAM created socket to kwalletd is in startkde > script. > > Move that code into kwallet-pam itself and add an autostart desktop file so > it can be used in plasma and outside of plasma (ie, gnome). Also add a check > for socat executable, which is required to connect to the socket. > > > Diffs > ----- > > CMakeLists.txt 8bd526e > pam_kwallet_init PRE-CREATION > pam_kwallet_init.desktop.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126843/diff/ > > > Testing > ------- > > Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, > I was still asked for password in GNOME. > > > Thanks, > > Armin K. > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
