> On Jan. 21, 2016, 11:06 a.m., Marco Martin wrote: > > I'm in general in favor of that, mostly for the scenario we find some > > actual rendering bug in the svg rendering code, that then gets cached > > Kai Uwe Broulik wrote: > Is there a better way to store the version? I recall in KCache or so you > can store custom properties? I don't want to end up with 16 MiB of unused > cache after every upgrade.
well, a kimagecache/kshareddatacache stores key/qbytearray, so you could also put a string in there... anyways, you shouldn't generate a new file, but rather just delete the existing cache when the version changes - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126642/#review91402 ----------------------------------------------------------- On Jan. 5, 2016, 6:11 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126642/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 6:11 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > We have the version number of the theme and some mtime heuristic yet still we > often end up with a broken theme after upgrades when it is changed, when > downstreams forget to adjust the version in their theme and so on. > > (I just noticed I never delete the old theme caches...) > > > Diffs > ----- > > src/plasma/private/theme_p.cpp 18419bb > > Diff: https://git.reviewboard.kde.org/r/126642/diff/ > > > Testing > ------- > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
