RefreshableScrollView
who sets requestingRefresh to false again? the app when it finishes
refreshing?
If so the property is more "refreshing" than "requestingRefresh"
API docs mising
Binding{} is better than 2 Connections to implement what effectively is a
binding
(and you have a bug here I'm sure, root.flickableItem.bottomMargin is set
to different things depending on whether the view or the content changed
last)
------------
ListItem
Given it doesn't contain a label AbstractListItem or BaseListItem would be
a better name
A subclass which then has the icon + text would be a good idea.
Docs for delegate for a section talks about showing a title. It doesn't.
Typo: otems -> items
height: paddingItem.childrenRect.height + Units.smallSpacing*2
is automatically bound to implicitHeight. No point rebinding it to the same
thing manually
What's the purpose of the checked state that only changes the UI layer?
Do we want to make it checkable like a button?
Need to change the UI if we're enabled or not (grey out or something)
------------
ListItemWithActions
docs for actions looks like you copied and pasted it from Page.
Rather than doing JS searching for QAction and QQC Action look into
qmlRegisterExtendedType for QAction to make the properties match lower in
the stack
-----------------------
Heading
I don't really want this in here *and* in Plasma extras long term
and the doc formatting is randomly different.
---------------------
General:
- accessibility needs doing
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
