> On Ян. 25, 2016, 10 преди обяд, Martin Gräßlin wrote:
> > Pointing out the obvious: though shall not animate window positions! This
> > needs to be moved to KWin (I'm disappointed that such code still exists in
> > frameworks). Which would kind of solve the problems automatically.
> >
> > Of course that comment is orthogonal to this review request: improvement is
> > always good.
>
> Anthony Fieroni wrote:
> Someone with KWin knowledge is needed here, i'm not so familiar with it
> or post link to example
It has special code to *prevent* sliding animation dialog.cpp:282
if (!(q->flags() & Qt::ToolTip)) {
KWindowEffects::SlideFromLocation slideLocation =
KWindowEffects::NoEdge;
.
.
.
> On Ян. 25, 2016, 10 преди обяд, Martin Gräßlin wrote:
> > src/declarativeimports/core/tooltip.cpp, line 160
> > <https://git.reviewboard.kde.org/r/126870/diff/2/?file=436482#file436482line160>
> >
> > why bind it to compositingActive?
>
> Anthony Fieroni wrote:
> To stop animated reposition when compositing is not active. How to fix,
> to remove it?
Any suggestions?
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/#review91561
-----------------------------------------------------------
On Ян. 24, 2016, 5:20 след обяд, Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126870/
> -----------------------------------------------------------
>
> (Updated Ян. 24, 2016, 5:20 след обяд)
>
>
> Review request for KDE Frameworks, Plasma and David Edmundson.
>
>
> Bugs: 354353
> http://bugs.kde.org/show_bug.cgi?id=354353
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip
> animation transition between item to decrease it permormance and looks quite
> ugly. If add new panel animation is *cool* as is. The perfermonce decrease
> can be cause due to swap use, or QPropertyAnimation issue, however we (you
> KDE defs and i *like a user*) wants plasmashell and it's components (like
> panel) to works *forever*
>
>
> Diffs
> -----
>
> src/declarativeimports/core/tooltip.cpp a5e223b
> src/declarativeimports/core/tooltipdialog.h 2ea8af9
> src/declarativeimports/core/tooltipdialog.cpp 6c3712e
>
> Diff: https://git.reviewboard.kde.org/r/126870/diff/
>
>
> Testing
> -------
>
> Workaround is quite simple:
> Animation is refreshed as is, pointer hasn't same lifetime as panel
> + Animation is disabled if compositing is not active
>
>
> Thanks,
>
> Anthony Fieroni
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
