----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126918/#review91782 -----------------------------------------------------------
Ship it! Ship it...but lets not do it 2 days before tagging. Wait for the next frameworks cycle. - David Edmundson On Jan. 28, 2016, 1:24 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126918/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 1:24 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this list was done because some applets broke with the new shared engine > stuff. > > since it's many workspace releases ago, unconditionally use the single engine > now. > > > Diffs > ----- > > src/plasmaquick/appletquickitem.cpp 48e78cd > src/plasmaquick/private/appletquickitem_p.h 94cfada > > Diff: https://git.reviewboard.kde.org/r/126918/diff/ > > > Testing > ------- > > every applet in the standard distribution still works correctly (the else > branch was never hit anymore) > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
