----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review91965 -----------------------------------------------------------
effects/morphingpopups/package/contents/code/morphingpopups.js (line 29) <https://git.reviewboard.kde.org/r/126968/#comment62744> backtrace? effects/morphingpopups/package/contents/code/morphingpopups.js (line 52) <https://git.reviewboard.kde.org/r/126968/#comment62745> calc distance only once. maybe operate on manhattan length? effects/morphingpopups/package/contents/code/morphingpopups.js (line 63) <https://git.reviewboard.kde.org/r/126968/#comment62746> old/new > 4 - presently looks like you're avoiding small ratios on first glance effects/morphingpopups/package/contents/code/morphingpopups.js (line 70) <https://git.reviewboard.kde.org/r/126968/#comment62747> enums (KWin.* should work, but am not sure) effects/morphingpopups/package/contents/code/morphingpopups.js (line 86) <https://git.reviewboard.kde.org/r/126968/#comment62748> a) let's have AnimationEffect::retarget(id, values...)?! - progress is a private detail of AnimationEffect. if that returns "bool", you also get around the cleanup issue. b) something tells me the duration should probably shorten in this case? effects/morphingpopups/package/contents/code/morphingpopups.js (line 143) <https://git.reviewboard.kde.org/r/126968/#comment62749> you should not even be here then ;-) - Thomas Lübking On Feb. 2, 2016, 2:04 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126968/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 2:04 p.m.) > > > Review request for kwin and Plasma. > > > Bugs: 347863 > https://bugs.kde.org/show_bug.cgi?id=347863 > > > Repository: kwin > > > Description > ------- > > this effect, derived from the Maximize one, will take the place of the manual > window position animation that Plasma tooltip are using. > this should cause less problems as animationg positions on X is very error > prone, plus it's less jarring when the tooltip sizes changes too, since that > gets animated as well (behavior similar to Window7 taskbar tooltips) > look: > https://www.youtube.com/watch?v=sxE23ZgkkpU > slow motion: > https://www.youtube.com/watch?v=jDByfncO568 > > replaces https://git.reviewboard.kde.org/r/126870 > > > Diffs > ----- > > effects/CMakeLists.txt dec50a9 > effects/backgroundcontrast/contrast.cpp 168deb0 > effects/blur/blur.cpp a360f03 > effects/morphingpopups/CMakeLists.txt PRE-CREATION > effects/morphingpopups/package/CMakeLists.txt PRE-CREATION > effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION > effects/morphingpopups/package/metadata.desktop PRE-CREATION > libkwineffects/kwinanimationeffect.h f59eedc > libkwineffects/kwinanimationeffect.cpp 579535b > scripting/scriptedeffect.h 2a77a2f > scripting/scriptedeffect.cpp 7ab065b > > Diff: https://git.reviewboard.kde.org/r/126968/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
