----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127024/#review92310 -----------------------------------------------------------
Indeed, mime filters supersede name filters. src/platformtheme/kdeplatformfiledialoghelper.cpp (line 268) <https://git.reviewboard.kde.org/r/127024/#comment62971> these 3 lines are duplicated in both branches -> move them out of the if/else? - David Faure On Feb. 11, 2016, 4:41 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127024/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 4:41 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: frameworkintegration > > > Description > ------- > > setMimeTypeFilters will call setNameFilter anyway, so we're not missing any > entries, on the other hand setMimeFilter will do some nice things using the > extra knowledge. > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb > > Diff: https://git.reviewboard.kde.org/r/127024/diff/ > > > Testing > ------- > > Tested it while porting okular. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
