-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127226/
-----------------------------------------------------------

(Updated Feb. 29, 2016, 10:15 p.m.)


Review request for Plasma.


Changes
-------

Actually this seems to fix changing theme from look&feel kcm.


Bugs: 359924
    http://bugs.kde.org/show_bug.cgi?id=359924


Repository: plasma-framework


Description
-------

Changing theme also changes color scheme making the pixmap cache invalid for 
monochrome icons.


Diffs
-----

  src/plasma/private/theme_p.cpp cca11f3 

Diff: https://git.reviewboard.kde.org/r/127226/diff/


Testing
-------

This makes the latest IconItem test (themeChange) pass.

There doesn't seem to be issue with this in plasmashell, because when changing 
theme from KCM, the application palette gets changed too (and pixmap cache is 
discarded on QEvent::ApplicationPaletteChange). But when only changing the 
theme with Plasma::Theme::setThemeName there is no palette change.


Thanks,

David Rosca

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to