----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/#review93101 -----------------------------------------------------------
src/plasma/svg.cpp (line 194) <https://git.reviewboard.kde.org/r/127260/#comment63478> KIconLoader::theme() may return nullptr, we've had crashes in the past in SSDM because of this. src/plasma/svg.cpp (line 232) <https://git.reviewboard.kde.org/r/127260/#comment63479> New connect syntax pls - Kai Uwe Broulik On März 2, 2016, 3:44 nachm., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127260/ > ----------------------------------------------------------- > > (Updated März 2, 2016, 3:44 nachm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this attempts to cache as well svg icons from the icon theme (invalidating as > well when the icon theme is updated) > > still to be done, to figure out to invalidate cache when the icon theme is > changed in the two cases: > * theme changed with plasmashell running > * theme changed with plasma shell not running > > > Diffs > ----- > > src/plasma/private/theme_p.h 69a8934 > src/plasma/private/theme_p.cpp 943d3af > src/plasma/svg.cpp ccd248a > > Diff: https://git.reviewboard.kde.org/r/127260/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
